On Mon, 12 Jun 2023 10:29:07 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 29 commits:
>>
>> - Merge branch 'master' into javadoc_fixes
>> - Fix issue with ArithmeticException not being wrapped in IAE for
>> SequenceLayout::withElementCount
>> Fix issue with IAE thrown instead of UOE for
>> ValueLayout::arrayElementVarHandle
>> Add apiNote to MemorySegment::address re. reachability
>> - Missed a review comment
>> - Use more `{@return}` tags
>> - Address review comments
>> - Fix wrong link in layout well-formedness doc
>> - Improve javadoc on supported linker layouts
>> - Tweak javadoc of MemorySegment::get/setUtf8String to deal with overflow
>> - Merge branch 'master' into javadoc_fixes
>> - Add overflow tests
>> - ... and 19 more: https://git.openjdk.org/jdk/compare/01455a07...b59edd93
>
> Closing, as the review is complete and I have to rebase against the forked 21
> repo. A similar PR will pop up soon :-)
> @mcimadamore Is there a reason that this shouldn't be integrated into the
> mainline?? Absent a compelling reason, fixes should be integrated first into
> the mainline (for 22) and then backported to 21.
This fix was targeting 21 - but then the repo has forked. It is my
understanding that fixes applied to the 21 fork will be forward-ported to 22
automatically.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14098#issuecomment-1587564381
