On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung <[email protected]> wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> missing 'L' for the array class name
src/java.base/share/classes/java/lang/Class.java line 395:
> 393: * attached thread), the system class loader is used.
> 394: *
> 395: * @param className the <a href="#binary-name">binary name</a>
> of the class
The new text is probably more correct, but it is less easy to understand. I
think "fully qualified name" of a class is a well-known term, but "binary name"
is rather unknown.
I suggest changing the text to mention both terms. For example like this:
Suggestion:
* @param className the <a href="#binary-name">binary name</a>) of the
class, for example its fully qualified name
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14528#discussion_r1233357830
