On Thu, 22 Jun 2023 05:48:34 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> move HEX256 to LongCache > > src/java.base/share/classes/java/lang/Long.java line 1233: > >> 1231: HEX256[i] = (char) (((hi < 10 ? '0' + hi : 'a' + hi - >> 10) << 8) >> 1232: + (lo < 10 ? '0' + lo : 'a' + lo - 10)); >> 1233: } > > Did you mean to put this in LongCache and is the intention it be archived or > are you putting this into its own holder class? Right now it's confusing as > HEX256 is not read from the archive. i have already used a separate holder class "DigitCache", and modifiers do not use private because I will submit a new optimization using HEX256 for Integer.toHexString and Long.toHexString ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14578#discussion_r1238135779
