On Wed, 28 Jun 2023 06:09:08 GMT, Chen Liang <li...@openjdk.org> wrote:
> This is a cleanup patch that fixes:
> 1. `ClassfileBuilder` should be sealed but was not; it's now sealed.
> 2. Various typo fixes, including spelling errors, wrong descriptions, and
> unnecessary full qualifications for classes in the same package.
>
> Requesting a review from @asotona. There's a few other more complex issues
> discovered, which I will describe on the mailing list to elicit a discussion
> for best solutions.
src/java.base/share/classes/jdk/internal/classfile/impl/ClassPrinterImpl.java
line 500:
> 498: case OfClass clv -> leafs("class",
> clv.className().stringValue());
> 499: case OfEnum ev -> leafs("enum class",
> ev.className().stringValue(),
> 500: "constant name",
> ev.constantName().stringValue());
Here the same typo is repeated in ClassPrinterTest, which actually fails after
the fix.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14687#discussion_r1244907999
