On Thu, 29 Jun 2023 13:45:09 GMT, Roger Riggs <[email protected]> wrote:
>> 温绍锦 has updated the pull request incrementally with two additional commits
>> since the last revision:
>>
>> - fix comments typo
>> - Update full name
>
> src/java.base/share/classes/java/util/HexDigits.java line 108:
>
>> 106: * Combine two hex shorts into one int based on big endian
>> 107: */
>> 108: static int digit(int b0, int b1) {
>
> The method name `digit` is not very informative.
> As it is package private it should be more descriptive and describe the
> parameters and result.
> Perhaps `packDigits` or `encodeAndPackHexDigits`.
can you create a new issue and i continue improving?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14578#discussion_r1248288730
