On Fri, 14 Jul 2023 11:21:02 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Simple tweak to remove the "available locales" section from default >> `-XshowSettings` output. >> >> Instead, it remains available with the `-XshowSettings:locale` option > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision: > > review feedback and bug id added to test thanks for the review @RogerRiggs - nice ideas but I'm not sure if it makes the code any clearer. I've implemented your suggestions but I feel we're polluting the main method with extra printlns and flow logic for the sake of locale output. Placing the help message option inside the "locale settings summary" style header works better also IMO. I think your suggestion means we print the helpful "more info with :locale " hint in the main showSettings call also, again pollution of main method. Best to let the flow of the locale setting logic stem from a printLocale(boolean summary) type method IMO ------------- PR Comment: https://git.openjdk.org/jdk/pull/14885#issuecomment-1636060048
