On Wed, 11 Jan 2023 13:19:32 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Before this change, when such a image was being > launched, the code would assume the byte order in the image to be the native > order of the host where the image is being launched. That would result in > failure to launch java, as noted in the linked issue. > > The commit in this PR, changes relevant places to not assume native order and > instead determine the byte order by reading the magic bytes in the image > file's header content. > > A new jtreg test has been added which reproduces the issue and verifies the > fix. This pull request has now been integrated. Changeset: 81c4e8f9 Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/81c4e8f916a04582698907291b6505d4484cf9c2 Stats: 279 lines in 9 files changed: 215 ins; 32 del; 32 mod 8304006: jlink should create the jimage file in the native endian for the target platform Co-authored-by: Mandy Chung <mch...@openjdk.org> Reviewed-by: alanb, mchung, rriggs ------------- PR: https://git.openjdk.org/jdk/pull/11943
