On Mon, 17 Jul 2023 17:21:50 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review changees > > test/jdk/java/lang/invoke/MethodHandleProxies/WrapperHiddenClassTest.java > line 165: > >> 163: () -> "incorrect dynamic module name: " + >> implModule.getName()); >> 164: >> 165: assertSame(implClass.getClassLoader(), >> implModule.getClassLoader(), > > I think this should check against `ifaceModule.getClassLoader()` instead, > right? Since the dynamic module is defined in the interface' class loader. Good catch! Yes, this should check against the interface's loader. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13197#discussion_r1265684091
