On Fri, 28 Jul 2023 08:49:20 GMT, Aleksey Shipilev <[email protected]> wrote:
> Fails like this:
>
>
> $ CONF=macosx-aarch64-server-fastdebug make images test
> TEST=java/util/Formatter/Padding.java
>
> ...
> STARTED Padding::padding '[216] -0000001.2, % 010.1f, -1.2'
> org.opentest4j.AssertionFailedError: expected: <-0000001.2> but was:
> <-0000001,2>
>
>
> Looks like a locale problem in test, so the simplest fix is to ask for a
> neutral Locale there.
test/jdk/java/util/Formatter/Padding.java line 312:
> 310: @MethodSource
> 311: void padding(String expected, String format, Object value) {
> 312: assertEquals(expected, String.format(Locale.ROOT, format,
> value));
I suggest using `Locale.US` instead of `Locale.ROOT`. Although it works,
`Locale.ROOT` is an invariant locale where theoretically you cannot assume the
decimal point is a period. Using `Locale.US` assures that assumption, and also
aligns with other similar test cases.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15066#discussion_r1277788433
