On Tue, 15 Aug 2023 20:03:46 GMT, Christoph <d...@openjdk.org> wrote:

>> Add new test case with sample modules that contains some 
>> requires/exports/uses/provides.
>> 
>> We are just unsure if and how we should add some last step of verificaiton 
>> with the extracted and decompiled class.
>> 
>> Follow up task from https://github.com/openjdk/jdk/pull/14408
>
> Christoph has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove obsolete jimage and decompile methods

Marked as reviewed by mchung (Reviewer).

test/jdk/tools/jlink/dedup/src/m4/p4/Main.java line 35:

> 33: 
> 34: public class Main {
> 35:     private final static int MODULE_SUB_METHOD_COUNT = 9;

This is leftover and should be deleted

-------------

PR Review: https://git.openjdk.org/jdk/pull/15234#pullrequestreview-1579396751
PR Review Comment: https://git.openjdk.org/jdk/pull/15234#discussion_r1295090298

Reply via email to