On Fri, 25 Aug 2023 13:35:04 GMT, Dan Heidinga <heidi...@openjdk.org> wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review feedback and javadoc clean up
>
> src/hotspot/share/classfile/javaClasses.cpp line 2990:
>
>> 2988: // direct calls for private and/or final non-static methods.
>> 2989: flags |= java_lang_invoke_MemberName::MN_IS_METHOD;
>> 2990: }
>
> Both the is_static and the else block set
> java_lang_invoke_MemberName::MN_IS_METHOD. Do we need to differentiate
> between the two cases or can they be collapsed?
yes they can be collapsed. I will update it.
> src/java.base/share/classes/java/lang/ClassFrameInfo.java line 48:
>
>> 46: }
>> 47: boolean isHidden() {
>> 48: return
>> SharedSecrets.getJavaLangInvokeAccess().isHiddenMember(flags &
>> MEMBER_INFO_FLAGS);
>
> Is it better to cache the JLIA in a static final similar to what
> StackFrameInfo does?
either way is fine. I can add a static field.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1305941281
PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1305942726
