On Mon, 4 Sep 2023 12:44:51 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Split Shift into ShiftLeft and ShiftRight + minor improvements. > > src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java > line 736: > >> 734: cb.i2l(); >> 735: popType(int.class); >> 736: pushType(long.class); > > These should happen along every code path, so, also in the case where the > input type is `long`. This will help catch cases where a previous binding > left something else than a `long` on the type stack. Ok. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15417#discussion_r1315030542
