On Mon, 4 Sep 2023 16:13:53 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add comments > > src/java.base/share/classes/java/lang/StringUTF16.java line 1534: > >> 1532: */ >> 1533: static int getChars(int i, int index, byte[] buf) { >> 1534: // Used by trusted callers. Assumes all necessary bounds >> checks have been done by the caller. > > Now these are a bit redundant since these methods are surrounded by a comment > to the same effect. I prefer inline comments like these, but we should avoid > having both. Comments are redundant, but I can't find a solution ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14699#discussion_r1315237072