On Tue, 12 Sep 2023 17:53:47 GMT, ExE Boss <d...@openjdk.org> wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> merge from master
>
> src/java.base/share/classes/java/time/LocalTime.java line 141:
>
>> 139: @Stable
>> 140: static final int[] DIGITS_K = new int[1000];
>> 141:
>
> Suggestion:
DIGITS_K has been removed
> src/java.base/share/classes/java/time/LocalTime.java line 179:
>
>> 177: int c3 = i % 10 + '0';
>> 178: DIGITS_K[i] = c0 + (c1 << 8) + (c2 << 16) + (c3 << 24);
>> 179: }
>
> Suggestion:
DIGITS_K has been removed
> src/java.base/share/classes/java/time/LocalTime.java line 1724:
>
>> 1722: v = DIGITS_K[rem2];
>> 1723: } else {
>> 1724: v = DIGITS_K[div - div2 * 1000];
>
> Suggestion:
>
> v = DecimalDigits.digitTriple(div - div2 * 1000);
DIGITS_K has been removed
> src/java.base/share/classes/java/time/LocalTime.java line 1740:
>
>> 1738: buf,
>> 1739: off,
>> 1740: DIGITS_K[rem1] & 0xffffff00 | (v >> 24)
>
> Suggestion:
>
> DecimalDigits.digitTriple(rem1) & 0xffffff00 | (v >> 24)
DIGITS_K has been removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15658#discussion_r1323811383
PR Review Comment: https://git.openjdk.org/jdk/pull/15658#discussion_r1323811309
PR Review Comment: https://git.openjdk.org/jdk/pull/15658#discussion_r1323811510
PR Review Comment: https://git.openjdk.org/jdk/pull/15658#discussion_r1323811428
