On Fri, 15 Sep 2023 20:24:35 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which is a continuation of >> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused >> code from the _sun.util.Calendar_ classes. >> >> `forceStandardTime` is always false. >> >> In addition, `locale` is never by used by _CalendarDate_ or any inheritors >> and can be removed. >> >> As a result, _ImmutableGregorianDate_ no longer needs to override the >> _setLocale_ method and throw UnsupportedOperationException. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > cleanup existing typos I have to retract the PR approval for the said reason src/java.base/share/classes/sun/util/calendar/ImmutableGregorianDate.java line 160: > 158: unsupported(); > 159: } > 160: This removal does not look right. The class claims `immutable`, and yet it is now allowing setting the locale. ------------- Changes requested by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15726#pullrequestreview-1629850335 PR Review Comment: https://git.openjdk.org/jdk/pull/15726#discussion_r1327862262
