On Wed, 20 Sep 2023 07:35:40 GMT, Chen Liang <li...@openjdk.org> wrote:
>> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry, >> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a >> typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or >> MethodTypeDesc). >> >> This API is not added to NameAndTypeEntry itself, for a NameAndTypeEntry >> only knows if its type should be a field or method type from the other >> entries that refer to it. >> >> This is one of the issues discussed in this mailing list thread: >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains four additional commits since > the last revision: > > - Merge branch 'master' into feature/cpentry-typesym > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/cpentry-typesym > - Use typeSymbol in asSymbol > - Add typeSymbol API for a few constant pool entries It looks good, thanks for the patch. ------------- Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14706#pullrequestreview-1636043719
