On Wed, 28 Jun 2023 07:02:17 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Summaries: >> 1. A few recommendations about updating the constant API is made at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html >> and I may update this patch shall the API changes be integrated before >> 2. One ASM library-specific test, `LambdaAsm` is removed. Others have their >> code generation infrastructure upgraded from ASM to Classfile API. >> 3. Most tests are included in tier1, but some are not: >> In `:jdk_io`: (tier2, part 2) >> >> test/jdk/java/io/Serializable/records/SerialPersistentFieldsTest.java >> test/jdk/java/io/Serializable/records/ProhibitedMethods.java >> test/jdk/java/io/Serializable/records/BadCanonicalCtrTest.java >> >> In `:jdk_instrument`: (tier 3) >> >> test/jdk/java/lang/instrument/RetransformAgent.java >> test/jdk/java/lang/instrument/NativeMethodPrefixAgent.java >> test/jdk/java/lang/instrument/asmlib/Instrumentor.java >> >> >> @asotona Would you mind reviewing? > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 14 commits: > > - Classfile object update > - Merge branch 'master' into invoke-test-classfile > - Merge branch 'master' into invoke-test-classfile > - Switch to ConstantDescs for <init> <clinit> and void constants > - Merge AnnotationsTest, remove ModuleTargetAttribute call > - Merge branch 'invoke-test-classfile' of https://github.com/liachmodded/jdk > into invoke-test-classfile > - Update test/jdk/java/lang/invoke/8022701/MHIllegalAccess.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - Merge branch 'master' into invoke-test-classfile > - Fix LambdaStackTrace after running > - formatting > - ... and 4 more: https://git.openjdk.org/jdk/compare/526dba1a...d0b6c2ae Should I wait for Classfile API transition to preview before I come back to this? ------------- PR Comment: https://git.openjdk.org/jdk/pull/13009#issuecomment-1728941810
