On Tue, 19 Sep 2023 20:03:51 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Fixed the failing (well, false-positive) test case. Made the following >> changes to the test: >> >> - Corrected the path to the mapping files directory >> - Made sure to fail if the directory path is incorrect >> - Took care of `GB18030` alias, which is dynamically derived at runtime >> - Provided `MS950_HKSCS.map`, which is simply a copy of `HKSCS2008.map` >> - Excluded other failing tests for IBM charsets that do not have map files. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Included the failed directory location in the exception message I suspect it was setup this way to allow the test tree be zipped up and the tests run without access to the src tree. In any case, the changes look okay, although a bit fragile to be reaching into the make/data tree for mapping data. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15807#pullrequestreview-1641399005
