On Mon, 25 Sep 2023 16:44:01 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tweak support for restricted methods >> >> Reviewed-by: jvernee, pminborg > > src/java.base/share/classes/java/lang/foreign/SegmentAllocator.java line 378: > >> 376: * {@return a new memory segment initialized with the elements in >> the provided byte array.} >> 377: * <p> >> 378: * The size of the allocated memory segment is the {@code >> elementLayout.byteSize() * elements.length}. > > Suggestion: > > * The size of the allocated memory segment is {@code > elementLayout.byteSize() * elements.length}. Here and also in all the other array-accepting methods. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15103#discussion_r1336149494