On Tue, 26 Sep 2023 12:38:46 GMT, Aleksei Voitylov <avoity...@openjdk.org> wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with >> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by >> default. The fix is to return true immediately if len is negative, since for >> negative length this condition will never be satisfied. >> >> Testing: JCK, JTREG passed with the fix with -XX:-CompactStrings on x86_64 >> and on ARM32. > > Aleksei Voitylov has updated the pull request incrementally with one > additional commit since the last revision: > > add regression test src/java.base/share/classes/java/lang/String.java line 2159: > 2157: return false; > 2158: } > 2159: // Any strings match if length < 0 Suggestion: // Any strings match if len < 0 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15906#discussion_r1337170256