On Fri, 29 Sep 2023 22:00:23 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains seven commits: >> >> - merge master and resolve conflicts >> - implement feedback >> - cleanup util classes in text/testlib >> - CollatorUtils -> CollatorTestUtils >> - remove IntlTest and CollatorTest. introduce CollatorUtils >> - manual changes >> - scripted changes > > test/jdk/java/util/Locale/LegacyCodesClassInvariant.java line 94: > >> 92: fail("Locale didn't maintain invariants for: "+lang); >> 93: fail(" got: "+loc); >> 94: fail(" excpeted: "+expected); > > This will only log the message in the first `fail()` invocation. This may be > auto-converted by the script, so you might want to check other places. Good point, adjusted all locations of this to be contained in one `fail()` call. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15954#discussion_r1341853125