On Tue, 3 Oct 2023 18:55:36 GMT, ExE Boss <d...@openjdk.org> wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed case in the test text >> - fixing javadoc >> - Unified implementations of InvokeInstruction::count, fixed javadoc and >> javap CodeWriter > > src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java > line 299: > >> 297: } >> 298: maxStringLength = currentMaxStringLength; >> 299: // The ClassFile's access_flags field is just after the last >> constant pool entry. > > This has nothing to do with the `ClassFile` API > Suggestion: > > // The Classfile's access_flags field is just after the last constant > pool entry.
Thanks for catching it, the refactoring was a bit more aggressive than expected. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1345214426
