On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> 
wrote:

>> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the 
>> details.
>
> Raffaello Giulietti has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Avoid localized integers in radix-out-of-range exception messages.

The reason parseUnsignedInt(CharSequence s, int beginIndex, int endIndex, int 
radix) cannot be inlined is because codeSize 350 is greater than default 
FreqInlineSize 325. Refactoring the exception handling code can be smaller than 
325 without using @ForceInline.

Refactoring the code related to exception handling can make the code smaller 
and easier to be inlined. The code for constructing exceptions in these methods 
is encapsulated into methods and can be easily maintained together.

https://github.com/rgiulietti/jdk/pull/1

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16050#issuecomment-1750369837
PR Comment: https://git.openjdk.org/jdk/pull/16050#issuecomment-1750391108

Reply via email to