On Tue, 10 Oct 2023 15:09:41 GMT, Adam Sotona <asot...@openjdk.org> wrote:
> JImageValidator has been recently converted to use ClassFile API and original > weak validation of class files was replaced with full class verification. > Unfortunately full class verification is too strong as it includes class > assignability verification according to class hierarchy resolution. > This patch relaxes class assignability verification from JImageValidator by > mocking ClassHierarchyResolver. > Resolution of all classes as interfaces during verification effectively > cancels the assignability verification (as interface assignability is not > verified). > > Please review this pull request. > > Thanks, > Adam On a side note, it seems weird that you need to pass a CHR again for verification instead of reusing the one from Class-File context object. Maybe we can consider moving verify to Class-File object for a new RFE? ------------- Marked as reviewed by liach (Author). PR Review: https://git.openjdk.org/jdk/pull/16123#pullrequestreview-1669984629
