On Thu, 12 Oct 2023 12:17:27 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> There are a few remaining places in java.base where the return value >> NULL-check of malloc is missing. This should better be adjusted. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > doabort in check method in case no memory can be allocated src/java.base/windows/native/libjli/cmdtoargs.c line 327: > 325: // "pgmname" rest of cmdline ie. pgmname + 2 double quotes + > space + cmdline from windows > 326: char* cptr = (char*) malloc(strlen(argv[0]) + sizeof(char) * 3 + > strlen(cmdline) + 1); > 327: if (cptr == NULL) return false; This doesn't look right, I think it has no choice but to print an error and doabort.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16160#discussion_r1356709874
