On Tue, 17 Oct 2023 23:34:56 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - comments from Alan and Ioi; add missing @run tag in the test
>> - Merge branch 'master' into improve-CDS-module-graph
>> - better way to check if a module is a JDK module
>> - initial review comments from Ioi
>> - 8316969: Improve CDS module graph support for --module option
>
> src/hotspot/share/classfile/modules.cpp line 567:
>
>> 565: #endif
>> 566:
>> 567: void Modules::dump_module_name() {
>
> This function should be `dump_main_module_name()`
I've changed the function name.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16016#discussion_r1364682871
