On Fri, 27 Oct 2023 18:00:38 GMT, Naoto Sato <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - additional cleanup/wording changes
>> - replace spec fix with private methods
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 560:
>
>> 558: * @see #previousDouble
>> 559: */
>> 560: public static double nextDouble (double d) {
>
> Is removing `final` OK here? Wouldn't this allow defining the static method
> in the subclass?
Right, we don't want those methods to now have the ability to be hidden. Got
carried away with the IDE suggested tips. Reverted here and in the other
occurrence, thanks for correcting.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16064#discussion_r1374928055
