On Fri, 3 Nov 2023 12:19:07 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
> 35: private static final AtomicLong numThrowables = new AtomicLong();
> 36:
> 37: public static void enable() throws NoSuchFieldException,
> SecurityException, IllegalArgumentException, IllegalAccessException {
SecurityException and IllegaArgumentException are unchecked so don't need them
in the throws declaration.
src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 44:
> 42:
> 43: public static void traceError(Class<?> clazz, String message) {
> 44: if (OutOfMemoryError.class.isAssignableFrom(clazz)) {
StackOverflowError is likely problematic too, maybe it should be
VirtualMachineError.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16493#discussion_r1383552825
PR Review Comment: https://git.openjdk.org/jdk/pull/16493#discussion_r1383552352
