On Wed, 8 Nov 2023 15:22:54 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 360 commits: >> >> - fixed condy tests >> - Merge branch 'master' into JDK-8308753-preview >> - Merge branch 'master' into JDK-8308753-preview >> >> # Conflicts: >> # test/jdk/tools/lib/tests/JImageValidator.java >> - fixed jdk.jfr >> - Merge branch 'master' into JDK-8308753-preview >> >> # Conflicts: >> # src/java.base/share/classes/module-info.java >> - applied javadoc fix suggestions >> - fixed new benchmark >> - Merge branch 'master' into JDK-8308753-preview >> >> # Conflicts: >> # >> src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java >> - removed trailing space >> - Merge branch 'master' into JDK-8308753-preview >> >> # Conflicts: >> # src/java.base/share/classes/module-info.java >> - ... and 350 more: https://git.openjdk.org/jdk/compare/7bc8e4c8...29c8fad3 > > test/jdk/jdk/classfile/SignaturesTest.java line 1: > >> 1: /* > > The new test in this file for classDesc bug needs a migration too. Good point, thank you. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1386878583
