On Wed, 8 Nov 2023 19:13:25 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in >> ProcessTools.createLimitedTestJavaProcessBuilder(). Only >> createTestJavaProcessBuilder() should use it like jtreg VM options. >> >> Adding the test thread factory requires the injection of arguments in the >> middle of the list. I don't think it makes sense to modify arguments in >> several places so I replaced it with the flag isLimited and moved all >> modifications in createJavaProcessBuilder(). >> >> Testing tier1-5. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > renamed arguments test/lib/jdk/test/lib/process/ProcessTools.java line 401: > 399: boolean expectSecondArg = false; > 400: boolean isTestThreadFactoryAdded = false; > 401: for (String cmd : commandArgs) { So `cmd` should really be `arg` right? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16442#discussion_r1387478034