On Fri, 10 Nov 2023 17:34:48 GMT, Daniel Fuchs <[email protected]> wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Multiple improvements to Gatherer and Gatherers javadoc and restructuring
>> of Gatherers.java to put public at the top of the file.
>> - Augmenting Gatherer tests to include default implementation in Stream
>
> src/java.base/share/classes/java/util/stream/Gatherer.java line 492:
>
>> 490: *
>> 491: * @apiNote This is best-effort only, once this returns true it
>> should
>> 492: * never return false again for the same instance.
>
> Suggestion:
>
> * @apiNote This is best-effort only, once this returns {@code true}
> it should
> * never return {@code false} again for the same instance.
Will fix all of these :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1389975495
