On Wed, 15 Nov 2023 22:08:19 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> test/jdk/java/lang/String/StringRacyConstructor.java line 190: >> >>> 188: if (printWarningCount == 0) { >>> 189: printWarningCount = 1; >>> 190: System.out.println("StringUTF16.compress returned >>> 0, may not be intrinsic"); >> >> It seems to me that the Java code for `StringUTF16.compress` also returns >> the index of the non-latin1 char, so I'm not sure I understand this. Just >> caution? > > There are separate implementations of the intrinsic for each platform. > This test would help identify the platforms on which the intrinsic had not > been updated to return the index instead of zero. Ah OK. So maybe the message should read `"intrinsic for StringUTF16.compress returned 0, may not have been updated"` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16425#discussion_r1395319817