On Fri, 24 Nov 2023 12:55:26 GMT, David Holmes <dhol...@openjdk.org> wrote:
> You didn't really need to rename the test even though there is now only one
> degraded method left.
True but it's wasn't good name for a test that only exercises one method.
> test/jdk/java/nio/channels/SocketChannel/SendUrgentData.java line 67:
>
>> 65: if (args.length > 0 && args[0].equals("-server")) {
>> 66: System.out.println(serverThread.getAddress());
>> 67: Thread.currentThread().suspend();
>
> If suspend throws then surely this test can't be functioning correctly! ???
The test has two modes. The automated (and default) runs a client+server in the
same VM. The other mode is for local/interactive testing where the client and
server are different commands, it's the interactive server run in this mode
that was doing the self-suspend.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16789#discussion_r1404336055
PR Review Comment: https://git.openjdk.org/jdk/pull/16789#discussion_r1404335282
