On Tue, 28 Nov 2023 15:00:43 GMT, Jim Laskey <jlas...@openjdk.org> wrote:
>> test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35: >> >>> 33: import java.lang.reflect.Modifier; >>> 34: >>> 35: public class TestImplicitClass { >> >> The test looks to be testing core reflection behavior (i.e. runtime >> behavior) and not compile-time behavior via javax.lang.model. >> >> Core reflection tests should be done too, but done the core libraries tests, >> not langtools tests. >> >> I might have overlooked it, but if some other exercise of compile-time >> modeling is not being done, please restore and update accordingly the sort >> of tests previously done in the now-deleted >> >> test/langtools/tools/javac/processing/model/element/TestUnnamedClass.java > > Added To clarify, there should be separate tests of what implicit classes look like under core reflection and under javax.lang.model. As currently written, the current test is a core reflection tests located under the javac/annotation processing test area, which is a misplacement. Please move this test to core reflection, replacing 445's test/jdk/java/lang/Class/UnnamedClass/TestUnnamedClass.java ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1409819479