On Thu, 16 Nov 2023 07:04:52 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Hi Magnus, the new x86-simd-sort 4.0 needs C++17 to compile. Will look into >> the changes needed for this library to compile without the C++17 standard >> and get back to you. >> >> Thanks, >> Vamsi > > Seems a bit odd to me too as the existing simd code seems to C code residing > in .cpp files for some reason. Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not just CXXFLAGS? Also @vamsi-parasa, did you check into if this really was needed and why? To be clear, I basically consider this an integration blocker. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1410405668
