On Tue, 28 Nov 2023 14:04:13 GMT, Alan Bateman <[email protected]> wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 2 lines in method scan
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3123:
>
>> 3121: throw unchecked;
>> 3122: } catch (Exception checked) {
>> 3123: throw new RuntimeException(checked);
>
> We should probably add a test that uses invoke(adaptInterruptible(callable))
> to check that a checked exception is wrapped, just in case it breaks with
> some future change.
Yes, somehow a test for this has been missing since first release. I added it
to tck/ForkJoinPoolTest.java
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16725#discussion_r1413154556