On Sat, 2 Dec 2023 15:42:18 GMT, fabioromano1 <d...@openjdk.org> wrote:
>> A faster and simpler way to generate random BigIntegers, avoiding eventually >> trimming of leading zeros in magnitude array. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision: > > Create RandomBigIntegers.java > > Create a benchmark to measure the performance of BigInteger(int, Random) > constructor implementation. test/micro/org/openjdk/bench/java/math/RandomBigIntegers.java line 31: > 29: } > 30: } > 31: } Can you convert the test to the JMH framework. It provides a solid framework for reliable performance measurement. An existing JMH test can be used as an example. Thanks ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16817#discussion_r1414454157
