On Mon, 20 Nov 2023 17:18:11 GMT, Per Minborg <pminb...@openjdk.org> wrote:
> Can we use `Objects::checkIndex` here instead? No, because these classes need to be compiled with `--release 8`. Javadoc: /** * @implNote This class needs to maintain JDK 8 source compatibility. * * It is used internally in the JDK to implement jimage/jrtfs access, * but also compiled and delivered as part of the jrtfs.jar to support access * to the jimage file provided by the shipped JDK by tools running on JDK 8. */ > Is this the correct exception type? I'm not sure, but I think it shouldn't matter, since the exception is never really thrown here for a valid jimage file. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16556#discussion_r1399536065 PR Review Comment: https://git.openjdk.org/jdk/pull/16556#discussion_r1399538948
