On Sat, 16 Dec 2023 16:37:16 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply suggestions from code review
>>
>> Co-authored-by: liach <7806504+li...@users.noreply.github.com>
>
> src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
> line 468:
>
>> 466: }
>> 467:
>> 468: private void emitStoreInsn(BasicType type, int index) {
>
> If we are going to use `localsMap` in every removed `emitStoreInsn`, perhaps
> we should restore it instead? Will also make it easier to move away from
> localsMap to CodeBuilder's tracking system.
Right, I'll restore emitLoadInsn and emitStoreInsn
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17108#discussion_r1429791664
