On Tue, 19 Dec 2023 17:41:57 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Users (not OpenJDK developers) don't know what the error code means. I think >> it's better to not have them. This is how other events work. If you want to >> guard against changes, I would export the package to the test. > > What about fixed `String`s rather than `int`s for the kind of error? > Something like `"SUID_INEFFECTIVE_ON_ENUM"`, and so on? > It would be nice to be able to use enums, but AFAIK that's not supported in > JFR. You could define them with an Enum but use the ordinal as the value for JFR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1431864329