On Wed, 20 Dec 2023 16:52:38 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

> > Alan actually did approve them on December 15.
> 
> I know, with requested changes. I didn't see the request transition to 
> "Ready" which is where it needs to be to `/integrate`.

Looking at the Github history I need to say that I cannot see that Alan 
approved *with change requests*. Maybe I am missing something. I see his 
approval on Dec 15 directly before my `/integrate` on the same day, but no 
change request *there*, and I can see his change request *after* my 
`/integrate` where he says "I think jai is right". But where do you see a 
change request from Alan *before* I posted `/integrate`? I am pretty sure you 
are right, but where actually do you see this in the Github history? Thanks. :-)

BTW, here is the "Ready" label you did not see: 
https://github.com/openjdk/jdk/pull/17119#event-11256913866

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17119#issuecomment-1864893934

Reply via email to