On Thu, 21 Dec 2023 12:01:25 GMT, Sergey Tsypanov <stsypa...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - performance improvements >> - SplitConstantPool performance fix > > src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java > line 62: > >> 60: private final Utf8Entry methodDesc; >> 61: private final SplitConstantPool cp; >> 62: private final LinkedList<Target> targets; > > Wouldn't it be better to use `ArrayDeque` instead of `LinkedList`? Good point, I'll change it, thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17121#discussion_r1434015586
