On Wed, 13 Dec 2023 20:06:03 GMT, Archie Cobbs <aco...@openjdk.org> wrote:

> One of the three `XMLStreamException` constructors that takes a `Throwable` 
> fails to pass it to the superclass constructor.
> 
> This simple patch fixes that omission.
> 
> It's worth considering if there is any code out there that is working around 
> this problem already by invoking `initCause()` manually. If so, that code 
> would start throwing an `IllegalStateException` after this change.
> 
> So a more conservative fix would be to just add another constructor taking 
> the same arguments in a different order. But then again that's not much 
> better than just saying "always use initCause() with the broken constructor", 
> i.e., don't change anything.
> 
> Hmm.

This pull request has now been integrated.

Changeset: 5852f3ea
Author:    Archie Cobbs <aco...@openjdk.org>
Committer: Jaikiran Pai <j...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/5852f3eafe4509a064c727371962ff249886e115
Stats:     63 lines in 2 files changed: 62 ins; 0 del; 1 mod

8322027: One XMLStreamException constructor fails to initialize cause

Reviewed-by: joehw, jpai

-------------

PR: https://git.openjdk.org/jdk/pull/17090

Reply via email to