On Thu, 4 Jan 2024 13:40:19 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updating copyright year of modified files. > > src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 957: > >> 955: __ align(CodeEntryAlignment); >> 956: StubCodeMark mark(this, "StubRoutines", stub_name); >> 957: address start = __ pc(); > > Could you please add some comments here why you are filling the data like > this? > Presumably, you are emitting 32 bits and 64 bits respectively, right? So the > cells have different size, correct? Thanks for the comment addition! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17261#discussion_r1442665042
