On Mon, 8 Jan 2024 16:17:47 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> ClassFile API performance related improvements have been separated from
>> #17121 into this PR.
>>
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the
>> Classfile API to generate proxy classes #17121
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since the last revision:
>
> applied suggested changes
src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java line
356:
> 354: }
> 355: case 'L' -> {
> 356: while (cur < end && descriptor.charAt(cur++) != ';');
Suggestion:
cur = descriptor.indexOf(';', cur) + 1;
if (cur == 0)
throw new IllegalArgumentException("Bad method
descriptor: " + descriptor);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17306#discussion_r1445001589
