On Tue, 9 Jan 2024 13:30:58 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> ClassFile API performance related improvements have been separated from >> #17121 into this PR. >> >> These improvements are important to minimize performance regression of >> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the >> Classfile API to generate proxy classes #17121 >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with three additional > commits since the last revision: > > - updated copyright year > - reverted custom method slots counting in StackCounter > - improved and extended GenerateStackMaps benchmarks and renamed to > CodeAttributeTools src/java.base/share/classes/jdk/internal/classfile/impl/StackMapDecoder.java line 83: > 81: vtis = new VerificationTypeInfo[methodType.parameterCount()]; > 82: } > 83: for(int pi = 0; pi < methodType.parameterCount(); pi++) { Suggestion: for (int pi = 0; pi < methodType.parameterCount(); pi++) { ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17306#discussion_r1452009672