On Tue, 16 Jan 2024 18:03:34 GMT, Claes Redestad <redes...@openjdk.org> wrote:

>> There's an unused concept of a pluginConfig that is passed into the jlink 
>> compress plugins, however we always pass null here and the code seems broken 
>> (the pluginConfig wouldn't have been stored properly). This seem to be a 
>> left-over from a more generic plugin design that never came to fruition.
>> 
>> This PR cleans out this code from the plugins and decompressors, while 
>> keeping the compressed header format intact for backwards compatibility (and 
>> in case we want to revisit this in the future)
>
> Claes Redestad has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Named offsets

Looks good.

-------------

Marked as reviewed by mchung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17443#pullrequestreview-1824528708

Reply via email to