On Wed, 24 Jan 2024 17:29:09 GMT, Vicente Romero <[email protected]> wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant test from checkUnconditionallyExact
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 405:
>
>> 403: */
>> 404: @SuppressWarnings("removal")
>> 405: private static MethodHandle generateInnerClass(MethodHandles.Lookup
>> caller, Class<?> selectorType, Object[] labels) {
>
> again a matter of style but it seems to me that the huge lambda inside of
> this method, starting in line 409, really wants to be a separate helper
> method. That will probably be a better refactoring as we won't be mixing byte
> code generation with method handles manipulation.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1466217863
