On Thu, 25 Jan 2024 10:21:26 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update year
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 404:
>
>> 402: */
>> 403: @SuppressWarnings("removal")
>> 404: private static MethodHandle generateInnerClass(MethodHandles.Lookup
>> caller, Class<?> selectorType, Object[] labels) {
>
> I think the name "labels" for the array here is unfortunate, because the code
> generation also contains "labels" which mean really "jump targets". Maybe
> `constants` or `labelConstants` or `caseConstants` ?
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1466217507
