On Tue, 30 Jan 2024 22:36:29 GMT, Naoto Sato <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update wording on quoting behavior
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 185:
>
>> 183: * <p>
>> 184: * For more sophisticated patterns, {@code ChoiceFormat} can be used
>> with
>> 185: * {@link MessageFormat} to produce accurate forms for singular and
>> plural:
>
> It sounds right to remove this restriction, but if we were to use `|` inside
> `Format`, shouldn't it still need to be single-quoted?
Right, the restriction shouldn't be removed, but rather updated. Fixed in
https://github.com/openjdk/jdk/pull/17640/commits/740686b2052a276b77529bea5444692e5bbe0078
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17640#discussion_r1472075577
